netdev - Re: [PATCH net] net: rps: fix error when CONFIG_RFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+MmOqo_=0sHzs8w3mT5uNXN_EAJO=teO-qYsxCPM6hqw@mail.gmail.com>
Date: Thu, 30 May 2024 06:44:59 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: kuba@...nel.org, pabeni@...hat.com, davem@...emloft.net, 
	netdev@...r.kernel.org, Jason Xing <kernelxing@...cent.com>, 
	John Sperbeck <jsperbeck@...gle.com>
Subject: Re: [PATCH net] net: rps: fix error when CONFIG_RFS_ACCEL is off

On Thu, May 30, 2024 at 5:28 AM Jason Xing <kerneljasonxing@...il.com> wrote:
>
> From: Jason Xing <kernelxing@...cent.com>
>
> John Sperbeck reported that if we turn off CONFIG_RFS_ACCEL, the 'head'
> is not defined, which will trigger compile error. So I move the 'head'
> out of the CONFIG_RFS_ACCEL scope.
>
> Fixes: 84b6823cd96b ("net: rps: protect last_qtail with rps_input_queue_tail_save() helper")
> Reported-by: John Sperbeck <jsperbeck@...gle.com>
> Closes: https://lore.kernel.org/all/20240529203421.2432481-1-jsperbeck@google.com/
> Signed-off-by: Jason Xing <kernelxing@...cent.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks John and Jason !