netdev - Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: Rebuild TC queues on VSI queue reconfiguration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 30 May 2024 07:01:30 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Karen Ostrowska <karen.ostrowska@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 Jan Sokolowski <jan.sokolowski@...el.com>,
 Wojciech Drewek <wojciech.drewek@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: Rebuild TC queues on
 VSI queue reconfiguration

Dear Karen, dear Jan,


Thank you for the patch.

Am 29.05.24 um 09:17 schrieb Karen Ostrowska:
> From: Jan Sokolowski <jan.sokolowski@...el.com>
> 
> TC queues needs to be correctly updated when the number of queues on

need

> a VSI is reconfigured, so netdev's queue and TC settings will be
> dynamically adjusted and could accurately represent the underlying
> hardware state after changes to the VSI queue counts.

Please document the test configuration, and how to test/verify your change.

> Fixes: 0754d65bd4be ("ice: Add infrastructure for mqprio support via ndo_setup_tc")
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> Signed-off-by: Jan Sokolowski <jan.sokolowski@...el.com>
> Signed-off-by: Karen Ostrowska <karen.ostrowska@...el.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_main.c | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index 1b61ca3a6eb6..a1798ec4d904 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -4136,7 +4136,7 @@ bool ice_is_wol_supported(struct ice_hw *hw)
>   int ice_vsi_recfg_qs(struct ice_vsi *vsi, int new_rx, int new_tx, bool locked)
>   {
>   	struct ice_pf *pf = vsi->back;
> -	int err = 0, timeout = 50;
> +	int i, err = 0, timeout = 50;

unsigned int

>   	if (!new_rx && !new_tx)
>   		return -EINVAL;
> @@ -4162,6 +4162,14 @@ int ice_vsi_recfg_qs(struct ice_vsi *vsi, int new_rx, int new_tx, bool locked)
>   
>   	ice_vsi_close(vsi);
>   	ice_vsi_rebuild(vsi, ICE_VSI_FLAG_NO_INIT);
> +
> +	ice_for_each_traffic_class(i) {
> +		if (vsi->tc_cfg.ena_tc & BIT(i))
> +			netdev_set_tc_queue(vsi->netdev,
> +					    vsi->tc_cfg.tc_info[i].netdev_tc,
> +					    vsi->tc_cfg.tc_info[i].qcount_tx,
> +					    vsi->tc_cfg.tc_info[i].qoffset);
> +	}
>   	ice_pf_dcb_recfg(pf, locked);
>   	ice_vsi_open(vsi);
>   done:


Kind regards,

Paul