netdev - Re: [iwl-next v3 03/15] ice: add basic devlink subfunctions support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240531181502.GG491852@kernel.org>
Date: Fri, 31 May 2024 19:15:02 +0100
From: Simon Horman <horms@...nel.org>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	jacob.e.keller@...el.com, michal.kubiak@...el.com,
	maciej.fijalkowski@...el.com, sridhar.samudrala@...el.com,
	przemyslaw.kitszel@...el.com, wojciech.drewek@...el.com,
	pio.raczynski@...il.com, jiri@...dia.com,
	mateusz.polchlopek@...el.com, shayd@...dia.com,
	kalesh-anakkur.purayil@...adcom.com
Subject: Re: [iwl-next v3 03/15] ice: add basic devlink subfunctions support

On Tue, May 28, 2024 at 06:38:01AM +0200, Michal Swiatkowski wrote:
> From: Piotr Raczynski <piotr.raczynski@...el.com>
> 
> Implement devlink port handlers responsible for ethernet type devlink
> subfunctions. Create subfunction devlink port and setup all resources
> needed for a subfunction netdev to operate. Configure new VSI for each
> new subfunction, initialize and configure interrupts and Tx/Rx resources.
> Set correct MAC filters and create new netdev.
> 
> For now, subfunction is limited to only one Tx/Rx queue pair.
> 
> Only allocate new subfunction VSI with devlink port new command.
> Allocate and free subfunction MSIX interrupt vectors using new API
> calls with pci_msix_alloc_irq_at and pci_msix_free_irq.
> 
> Support both automatic and manual subfunction numbers. If no subfunction
> number is provided, use xa_alloc to pick a number automatically. This
> will find the first free index and use that as the number. This reduces
> burden on users in the simple case where a specific number is not
> required. It may also be slightly faster to check that a number exists
> since xarray lookup should be faster than a linear scan of the dyn_ports
> xarray.
> 
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> Co-developed-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Piotr Raczynski <piotr.raczynski@...el.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

Reviewed-by: Simon Horman <horms@...nel.org>