[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a62b992b-c327-4da1-babb-5940d9a3fe0f@kernel.org>
Date: Fri, 31 May 2024 10:53:29 +0200
From: Matthieu Baerts <matttbe@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>, edumazet@...gle.com, pabeni@...hat.com
Cc: davem@...emloft.net, netdev@...r.kernel.org, mptcp@...ts.linux.dev,
martineau@...nel.org, borisp@...dia.com, willemdebruijn.kernel@...il.com
Subject: Re: [PATCH net-next 1/3] tcp: wrap mptcp and decrypted checks into
tcp_skb_can_collapse_rx()
Hi Jakub,
On 31/05/2024 01:36, Jakub Kicinski wrote:
> tcp_skb_can_collapse() checks for conditions which don't make
> sense on input. Because of this we ended up sprinkling a few
> pairs of mptcp_skb_can_collapse() and skb_cmp_decrypted() calls
> on the input path. Group them in a new helper. This should make
> it less likely that someone will check mptcp and not decrypted
> or vice versa when adding new code.
>
> This implicitly adds a decrypted check early in tcp_collapse().
> AFAIU this will very slightly increase our ability to collapse
> packets under memory pressure, not a real bug.
Good idea! Thank you for this refactoring, and for having cc'd MPTCP ML:
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
Powered by blists - more mailing lists