netdev - [PATCH V3] ext4: check hash version and filesystem casefolded consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240531085647.2918240-1-lizhi.xu@windriver.com>
Date: Fri, 31 May 2024 16:56:47 +0800
From: Lizhi Xu <lizhi.xu@...driver.com>
To: <ebiggers@...nel.org>
CC: <adilger.kernel@...ger.ca>, <coreteam@...filter.org>,
        <davem@...emloft.net>, <fw@...len.de>, <jaegeuk@...nel.org>,
        <kadlec@...filter.org>, <kuba@...nel.org>,
        <linux-ext4@...r.kernel.org>, <linux-fscrypt@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <lizhi.xu@...driver.com>,
        <netdev@...r.kernel.org>, <netfilter-devel@...r.kernel.org>,
        <pablo@...filter.org>,
        <syzbot+340581ba9dceb7e06fb3@...kaller.appspotmail.com>,
        <syzkaller-bugs@...glegroups.com>, <tytso@....edu>
Subject: [PATCH V3] ext4: check hash version and filesystem casefolded consistent

When mounting the ext4 filesystem, if the hash version and casefolded are not
consistent, exit the mounting.

Reported-by: syzbot+340581ba9dceb7e06fb3@...kaller.appspotmail.com
Signed-off-by: Lizhi Xu <lizhi.xu@...driver.com>
---
 fs/ext4/super.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index c682fb927b64..c0036e3922c2 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5262,6 +5262,9 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
 		goto failed_mount;
 
 	ext4_hash_info_init(sb);
+	if (es->s_def_hash_version == DX_HASH_SIPHASH && 
+	    !ext4_has_feature_casefold(sb))
+		goto failed_mount;
 
 	err = ext4_handle_clustersize(sb);
 	if (err)
-- 
2.43.0