netdev - Re: [PATCH net-next 1/3] dt-bindings: net: airoha: Add EN7581 ethernet controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 1 Jun 2024 10:46:34 +0200
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: angelogioacchino.delregno@...labora.com, pabeni@...hat.com,
	devicetree@...r.kernel.org, upstream@...oha.com, conor@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, davem@...emloft.net,
	will@...nel.org, nbd@....name, lorenzo.bianconi83@...il.com,
	catalin.marinas@....com, netdev@...r.kernel.org,
	edumazet@...gle.com, kuba@...nel.org, benjamin.larsson@...exis.eu,
	conor+dt@...nel.org, linux-arm-kernel@...ts.infradead.org,
	robh+dt@...nel.org
Subject: Re: [PATCH net-next 1/3] dt-bindings: net: airoha: Add EN7581
 ethernet controller

> 
> On Fri, 31 May 2024 12:22:18 +0200, Lorenzo Bianconi wrote:
> > Introduce device-tree binding documentation for Airoha EN7581 ethernet
> > mac controller.
> > 
> > Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> > ---
> >  .../bindings/net/airoha,en7581.yaml           | 106 ++++++++++++++++++
> >  1 file changed, 106 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/net/airoha,en7581.yaml
> > 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/net/airoha,en7581.example.dts:27:18: fatal error: dt-bindings/reset/airoha,en7581-reset.h: No such file or directory
>    27 |         #include <dt-bindings/reset/airoha,en7581-reset.h>
>       |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/net/airoha,en7581.example.dtb] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
> make: *** [Makefile:240: __sub-make] Error 2
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/97946e955b05d21fe96ef8f98f794831cbd7c3b5.1717150593.git.lorenzo@kernel.org
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
> 

Hi Rob,

ack, right. The issue is the airoha reset patches [0] have not been applied yet
but they are in my development tree so 'make dt_binding_check' works fine for
me. Sorry for the noise.
I am wondering what is the right approach in this case. Should we wait for dts
prerequisite patches to be in net-next tree or are dts patches of this series
going to be applied to a different tree with respect to driver core that is
going to net-next?

Regards,
Lorenzo

[0] https://patchwork.kernel.org/project/linux-clk/cover/cover.1715948628.git.lorenzo@kernel.org/

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)