netdev - Re: [PATCH] net: phy: rtl8211f add ethtool set wol function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <098c355c-a7b7-4570-988f-56e7d54989f3@lunn.ch>
Date: Sun, 2 Jun 2024 16:21:02 +0200
From: Andrew Lunn <andrew@...n.ch>
To: yangfeng <yangfeng59949@....com>
Cc: hkallweit1@...il.com, linux@...linux.org.uk, netdev@...r.kernel.org,
	Yang Feng <yangfeng@...inos.cn>
Subject: Re: [PATCH] net: phy: rtl8211f add ethtool set wol function

On Sun, Jun 02, 2024 at 04:46:57PM +0800, yangfeng wrote:
> From: Yang Feng <yangfeng@...inos.cn>
> 
> Stmmac+RTL8211F cannot set network wake-up, add related functions
> - read: ethtool NETDEV
> - write: ethtool -s NETDEV wol g/d

I don't see any interrupt handling here. How does the wake up actually
happen on your board? Is a pin of the PHY connected to a PMU? Maybe
the more normal way is that the PHY interrupt pin is used to
GPIO/interrupt controller which can wake the system. But that often
requires enabling the interrupt.

It would be good to document how it works for your board. That will
help others who need to use the interrupt method not break WoL for
your board.

       Andrew