netdev - Re: [PATCH net-next 3/3] net: airoha: Introduce ethernet support for EN7581 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zly1fi5kr9YNo2yN@lore-desk>
Date: Sun, 2 Jun 2024 20:10:06 +0200
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, nbd@....name, lorenzo.bianconi83@...il.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, conor@...nel.org,
	linux-arm-kernel@...ts.infradead.org, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	devicetree@...r.kernel.org, catalin.marinas@....com,
	will@...nel.org, upstream@...oha.com,
	angelogioacchino.delregno@...labora.com,
	benjamin.larsson@...exis.eu
Subject: Re: [PATCH net-next 3/3] net: airoha: Introduce ethernet support for
 EN7581 SoC

> > +static void airoha_remove(struct platform_device *pdev)
> > +{
> > +	struct airoha_eth *eth = platform_get_drvdata(pdev);
> > +	int i;
> > +
> > +	debugfs_remove(eth->debugfs_dir);
> > +
> > +	airoha_qdma_for_each_q_rx(eth, i) {
> > +		struct airoha_queue *q = &eth->q_rx[i];
> > +
> > +		netif_napi_del(&q->napi);
> > +		airoha_qdma_clenaup_rx_queue(q);
> > +		page_pool_destroy(q->page_pool);
> > +	}
> > +
> > +	for (i = 0; i < ARRAY_SIZE(eth->q_tx_irq); i++)
> > +		netif_napi_del(&eth->q_tx_irq[i].napi);
> > +	for (i = 0; i < ARRAY_SIZE(eth->q_tx); i++)
> > +		airoha_qdma_clenaup_tx_queue(&eth->q_tx[i]);
> > +}
> 
> You don't appear to unregister the netdev. remove() should basically
> be the reverse of probe().
> 
>     Andrew

ack, I will fix it in v2.

Regards,
Lorenzo

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)