netdev - Re: [PATCH net-next] seg6: fix parameter passing when calling NF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zl4YGQ3pqEobNTAl@calendula>
Date: Mon, 3 Jun 2024 21:23:05 +0200
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Jianguo Wu <wujianguo106@....com>
Cc: netdev <netdev@...r.kernel.org>, contact@...elbtn.com,
	David Ahern <dsahern@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next] seg6: fix parameter passing when calling
 NF_HOOK() in End.DX4 and End.DX6 behaviors

Hi,

On Thu, May 30, 2024 at 03:43:38PM +0800, Jianguo Wu wrote:
> From: Jianguo Wu <wujianguo@...natelecom.cn>
> 
> input_action_end_dx4() and input_action_end_dx6() call NF_HOOK() for PREROUTING hook,
> for PREROUTING hook, we should passing a valid indev, and a NULL outdev to NF_HOOK(),
> otherwise may trigger a NULL pointer dereference, as below:

Could you also add a selftest to improve coverage of this infrastructure?

Thanks.