netdev - Re: [PATCH net v5 2/2] mptcp: count CLOSE-WAIT sockets for MPTCP_MIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35b92abd-73a0-4033-b83d-ec84922711f8@kernel.org>
Date: Mon, 3 Jun 2024 21:48:02 +0200
From: Matthieu Baerts <matttbe@...nel.org>
To: Jason Xing <kerneljasonxing@...il.com>, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, davem@...emloft.net, dsahern@...nel.org,
 martineau@...nel.org, geliang@...nel.org
Cc: netdev@...r.kernel.org, mptcp@...ts.linux.dev,
 Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net v5 2/2] mptcp: count CLOSE-WAIT sockets for
 MPTCP_MIB_CURRESTAB

Hi Jason,

On 03/06/2024 19:02, Jason Xing wrote:
> From: Jason Xing <kernelxing@...cent.com>
> 
> Like previous patch does in TCP, we need to adhere to RFC 1213:
> 
>   "tcpCurrEstab OBJECT-TYPE
>    ...
>    The number of TCP connections for which the current state
>    is either ESTABLISHED or CLOSE- WAIT."
> 
> So let's consider CLOSE-WAIT sockets.
> 
> The logic of counting
> When we increment the counter?
> a) Only if we change the state to ESTABLISHED.
> 
> When we decrement the counter?
> a) if the socket leaves ESTABLISHED and will never go into CLOSE-WAIT,
> say, on the client side, changing from ESTABLISHED to FIN-WAIT-1.
> b) if the socket leaves CLOSE-WAIT, say, on the server side, changing
> from CLOSE-WAIT to LAST-ACK.

Thank you for the update!

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.