netdev - Re: [PATCH 1/2 net-next] devlink: Constify the 'table_ops' parameter of devl_dpipe_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37e0f1cd-d6b4-4b7c-b386-7d31423ac7c8@intel.com>
Date: Mon, 3 Jun 2024 10:45:57 +0200
From: Wojciech Drewek <wojciech.drewek@...el.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, <idosch@...dia.com>,
	<petrm@...dia.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <jiri@...nulli.us>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 1/2 net-next] devlink: Constify the 'table_ops' parameter
 of devl_dpipe_table_register()



On 02.06.2024 16:18, Christophe JAILLET wrote:
> "struct devlink_dpipe_table_ops" only contains some function pointers.
> 
> Update "struct devlink_dpipe_table" and the 'table_ops' parameter of
> devl_dpipe_table_register() so that structures in drivers can be
> constified.
> 
> Constifying these structures will move some data to a read-only section, so
> increase overall security.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---

Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>

>  include/net/devlink.h | 4 ++--
>  net/devlink/dpipe.c   | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/net/devlink.h b/include/net/devlink.h
> index 35eb0f884386..db5eff6cb60f 100644
> --- a/include/net/devlink.h
> +++ b/include/net/devlink.h
> @@ -352,7 +352,7 @@ struct devlink_dpipe_table {
>  	bool resource_valid;
>  	u64 resource_id;
>  	u64 resource_units;
> -	struct devlink_dpipe_table_ops *table_ops;
> +	const struct devlink_dpipe_table_ops *table_ops;
>  	struct rcu_head rcu;
>  };
>  
> @@ -1751,7 +1751,7 @@ void devl_sb_unregister(struct devlink *devlink, unsigned int sb_index);
>  void devlink_sb_unregister(struct devlink *devlink, unsigned int sb_index);
>  int devl_dpipe_table_register(struct devlink *devlink,
>  			      const char *table_name,
> -			      struct devlink_dpipe_table_ops *table_ops,
> +			      const struct devlink_dpipe_table_ops *table_ops,
>  			      void *priv, bool counter_control_extern);
>  void devl_dpipe_table_unregister(struct devlink *devlink,
>  				 const char *table_name);
> diff --git a/net/devlink/dpipe.c b/net/devlink/dpipe.c
> index a72a9292efc5..55009b377447 100644
> --- a/net/devlink/dpipe.c
> +++ b/net/devlink/dpipe.c
> @@ -839,7 +839,7 @@ EXPORT_SYMBOL_GPL(devlink_dpipe_table_counter_enabled);
>   */
>  int devl_dpipe_table_register(struct devlink *devlink,
>  			      const char *table_name,
> -			      struct devlink_dpipe_table_ops *table_ops,
> +			      const struct devlink_dpipe_table_ops *table_ops,
>  			      void *priv, bool counter_control_extern)
>  {
>  	struct devlink_dpipe_table *table;