netdev - Re: "ERROR: modpost: "icssg_queue_pop" [...] undefined" on arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d22ac7e-c505-430b-82cc-6b14b04f3c90@leemhuis.info>
Date: Mon, 3 Jun 2024 11:24:23 +0200
From: Thorsten Leemhuis <linux@...mhuis.info>
To: MD Danish Anwar <danishanwar@...com>,
 Dan Carpenter <dan.carpenter@...aro.org>, Jan Kiszka
 <jan.kiszka@...mens.com>, Simon Horman <horms@...nel.org>,
 Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <vladimir.oltean@....com>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Niklas Schnelle <schnelle@...ux.ibm.com>, Arnd Bergmann <arnd@...db.de>,
 Diogo Ivo <diogo.ivo@...mens.com>, Roger Quadros <rogerq@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>
Cc: linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, srk@...com,
 Vignesh Raghavendra <vigneshr@...com>
Subject: Re: "ERROR: modpost: "icssg_queue_pop" [...] undefined" on arm64

On 03.06.24 10:14, MD Danish Anwar wrote:
> On 03/06/24 12:39 pm, Thorsten Leemhuis wrote:
>> On 28.05.24 13:37, MD Danish Anwar wrote:
>>> Introduce helper functions to configure firmware FDB tables, VLAN tables
>>> and Port VLAN ID settings to aid adding Switch mode support.
>>>
>>> Signed-off-by: MD Danish Anwar <danishanwar@...com>
>>
>> Hi! Since Friday I get a compile error in my -next builds for Fedora:
>>
>> ERROR: modpost: "icssg_queue_push"
>> [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
>> ERROR: modpost: "icssg_queue_pop"
>> [drivers/net/ethernet/ti/icssg-prueth-sr1.ko] undefined!
> 
> Before posting the patches I had tested them with defconfig and I didn't
> see any ERRORs.
> 
> I think in the config that you are using most probably
> CONFIG_TI_ICSSG_PRUETH_SR1 is enabled. The patch adds APIs in
> icssg_config.c which uses APIs added in icssg_qeueus.c.
> 
> Now CONFIG_TI_ICSSG_PRUETH_SR1 also uses icssg_config.c but
> icssg_queues.c is not built for SR1 as a result this error is coming.
> 
> Fix for this will be to build icssg_queues as well for SR1 driver.
> 
> I will test the fix and post it to net-next soon.

thx!

>> Looks like this problem was found and reported mid May by the kernel
>> test robot already, which identified a earlier version of the patch I'm
>> replying to to be the cause:
>> https://lore.kernel.org/all/202405182038.ncf1mL7Z-lkp@intel.com/
>>
>> That and the fact that the patch showed up in -next on Friday makes me
>> assume that my problem is caused by this change as well as well. A build
>> log can be found here:
>> https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-39-aarch64/07523690-next-next-all/builder-live.log.gz
>>
>> I don't have the .config at hand, but can provide it when needed.
> 
> Yes that would be helpful. If possible just check in the .config what
> symbols are enabled related to ICSS. (`cat .config | grep ICSS`)

I can't easily access the .config used the build system used for the
build, but unless I did something stupid it should be identical to this one:
https://www.leemhuis.info/files/misc/kernel-6.10.0-aarch64.config

FWIW, that .config is generated by some scripts Fedora uses when
building their kernels.

$ grep ICSS kernel-6.10.0-aarch64.config
CONFIG_TI_ICSSG_PRUETH=m
CONFIG_TI_ICSSG_PRUETH_SR1=m
CONFIG_TI_ICSS_IEP=m

HTH, Ciao, Thorsten