netdev - Re: [PATCH net-next v13 12/15] net: stmmac: Fixed failure to set network speed to 1000.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ba14d835ff12f479eeced585b9336c1e6219d54@linux.dev>
Date: Tue, 04 Jun 2024 11:29:43 +0000
From: si.yanteng@...ux.dev
To: "Russell King (Oracle)" <linux@...linux.org.uk>, "Huacai Chen"
 <chenhuacai@...nel.org>, fancer.lancer@...il.com
Cc: "Yanteng Si" <siyanteng@...ngson.cn>, andrew@...n.ch,
 hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com,
 Jose.Abreu@...opsys.com, guyinggang@...ngson.cn, netdev@...r.kernel.org,
 chris.chenfeiyang@...il.com
Subject: Re: [PATCH net-next v13 12/15] net: stmmac: Fixed failure to set
 network speed to 1000.

2024年5月30日 15:22, "Russell King (Oracle)" <linux@...linux.org.uk> 写到:

Hi, Russell, Serge,

> 
> On Thu, May 30, 2024 at 10:25:01AM +0800, Huacai Chen wrote:
> 
> > 
> > Hi, Yanteng,
> > 
> >  
> > 
> >  The title should be "Fix ....." rather than "Fixed .....", and it is
> > 
> 
> I would avoid the ambiguous "Fix" which for stable folk imply that this
> 
> is a bug fix - but it isn't. It's adding support for requiring 1G
> 
> speeds to always be negotiated.
Oh, I get it now. Thanks!

> 
> I would like this patch to be held off until more thought can be put
> 
> into how to handle this without having a hack in the driver (stmmac
> 
> has too many hacks and we're going to have to start saying no to
> 
> these.)
Yeah, you have a point there, but I would also like to hear Serge's opinion.

Thanks,
Yanteng