netdev - Re: [PATCH net-next] net: bridge: fix an inconsistent indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5C3E0B27-B3FF-44EC-98EB-FA43B0790957@blackwall.org>
Date: Tue, 04 Jun 2024 17:10:52 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Paolo Abeni <pabeni@...hat.com>, Chen Hanxiao <chenhx.fnst@...itsu.com>,
 Roopa Prabhu <roopa@...dia.com>, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>
CC: bridge@...ts.linux.dev, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: bridge: fix an inconsistent indentation

On June 4, 2024 4:57:12 PM GMT+03:00, Paolo Abeni <pabeni@...hat.com> wrote:
>On Fri, 2024-05-31 at 16:54 +0800, Chen Hanxiao wrote:
>> Smatch complains:
>> net/bridge/br_netlink_tunnel.c:
>>    318 br_process_vlan_tunnel_info() warn: inconsistent indenting
>> 
>> Fix it with a proper indenting
>> 
>> Signed-off-by: Chen Hanxiao <chenhx.fnst@...itsu.com>
>
>My take is that purely format changes should be part of
>larger/features-based change, to avoid any later stable fix harder for
>no real reason.
>
>Thanks,
>
>Paolo
>

This is new, I don't see anything wrong with fixing bad indentation.
Waiting for a set which touches this code which hasn't changed for a long time ib order to fix it is doesn't sound 
good to me. It is very trivial to resolve for anyone.

Cheers,
 Nik