netdev - Re: [PATCH v2 0/4] bugfix: Introduce sendpages_ok() to check sendpage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240604043041.GA28886@lst.de>
Date: Tue, 4 Jun 2024 06:30:41 +0200
From: Christoph Hellwig <hch@....de>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Christoph Hellwig <hch@....de>, Ofir Gal <ofir.gal@...umez.com>,
	davem@...emloft.net, linux-block@...r.kernel.org,
	linux-nvme@...ts.infradead.org, netdev@...r.kernel.org,
	ceph-devel@...r.kernel.org, dhowells@...hat.com,
	edumazet@...gle.com, pabeni@...hat.com, kbusch@...nel.org,
	axboe@...nel.dk, sagi@...mberg.me, philipp.reisner@...bit.com,
	lars.ellenberg@...bit.com, christoph.boehmwalder@...bit.com,
	idryomov@...il.com, xiubli@...hat.com
Subject: Re: [PATCH v2 0/4] bugfix: Introduce sendpages_ok() to check
 sendpage_ok() on contiguous pages

On Sat, Jun 01, 2024 at 03:36:10PM -0700, Jakub Kicinski wrote:
> On Fri, 31 May 2024 09:32:14 +0200 Christoph Hellwig wrote:
> > I still find it hightly annoying that we can't have a helper that
> > simply does the right thing for callers, but I guess this is the
> > best thing we can get without a change of mind from the networking
> > maintainers..
> 
> Change mind about what? Did I miss a discussion?

Having a net helper to just send some memory in the most efficient
way and leave it up to the networking code to decide if it wants
to use sendpage or sendmsg internally as needed instead of burdening
the caller.

This happened before sendpage_ok was added, so probably in 2020
and most involved Dave and not you.