netdev - Re: [PATCH 0/9] Intel Wired LAN Driver Updates 2024-06-03

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2e0cc718-38eb-47fb-ac02-150ecc9858d8@amd.com>
Date: Mon, 3 Jun 2024 17:14:05 -0700
From: "Nelson, Shannon" <shannon.nelson@....com>
To: Jacob Keller <jacob.e.keller@...el.com>,
 David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>,
 Jakub Kicinski <kuba@...nel.org>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Aleksandr Loktionov <aleksandr.loktionov@...el.com>,
 Alexander Lobakin <aleksander.lobakin@...el.com>,
 Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>,
 Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
 Wojciech Drewek <wojciech.drewek@...el.com>,
 Sujai Buvaneswaran <sujai.buvaneswaran@...el.com>,
 Michal Schmidt <mschmidt@...hat.com>, Sunil Goutham <sgoutham@...vell.com>,
 Eric Joyner <eric.joyner@...el.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Karen Ostrowska <karen.ostrowska@...el.com>,
 Vitaly Lifshits <vitaly.lifshits@...el.com>,
 Menachem Fogel <menachem.fogel@...el.com>,
 Naama Meir <naamax.meir@...ux.intel.com>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH 0/9] Intel Wired LAN Driver Updates 2024-06-03

On 6/3/2024 3:38 PM, Jacob Keller wrote:
> 
> This series includes miscellaneous improvements for the ice and igc, as
> well as a cleanup to the Makefiles for all Intel net drivers.
> 
> Andy fixes all of the Intel net driver Makefiles to use the documented
> '*-y' syntax for specifying object files to link into kernel driver
> modules, rather than the '*-objs' syntax which works but is documented as
> reserved for user-space host programs.
> 
> Michal Swiatkowski has four patches to prepare the ice driver for
> supporting subfunctions. This includes some cleanups to the locking around
> devlink port creation as well as improvements to the driver's handling of
> port representor VSIs.
> 
> Jacob has a cleanup to refactor rounding logic in the ice driver into a
> common roundup_u64 helper function.
> 
> Michal Schmidt replaces irq_set_affinity_hint() to use
> irq_update_affinity_hint() which behaves better with user-applied affinity
> settings.
> 
> Eric improves checks to the ice_vsi_rebuild() function, checking and
> reporting failures when the function is called during a reset.
> 
> Vitaly adds support for ethtool .set_phys_id, used for blinking the device
> LEDs to identify the physical port for which a device is connected to.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>

Aside from a couple of minor questions on 9/9, these all look reasonable.

For the set:
Reviewed-by: Shannon Nelson <shannon.nelson@....com>


> ---
> Andy Shevchenko (1):
>        net: intel: Use *-y instead of *-objs in Makefile
> 
> Eric Joyner (1):
>        ice: Check all ice_vsi_rebuild() errors in function
> 
> Jacob Keller (1):
>        ice: add and use roundup_u64 instead of open coding equivalent
> 
> Michal Schmidt (1):
>        ice: use irq_update_affinity_hint()
> 
> Michal Swiatkowski (4):
>        ice: store representor ID in bridge port
>        ice: move devlink locking outside the port creation
>        ice: move VSI configuration outside repr setup
>        ice: update representor when VSI is ready
> 
> Vitaly Lifshits (1):
>        igc: add support for ethtool.set_phys_id
> 
>   drivers/net/ethernet/intel/e1000/Makefile          |  2 +-
>   drivers/net/ethernet/intel/e1000e/Makefile         |  7 +-
>   drivers/net/ethernet/intel/i40e/Makefile           |  2 +-
>   drivers/net/ethernet/intel/iavf/Makefile           |  5 +-
>   drivers/net/ethernet/intel/ice/devlink/devlink.c   |  2 -
>   .../net/ethernet/intel/ice/devlink/devlink_port.c  |  4 +-
>   drivers/net/ethernet/intel/ice/ice_eswitch.c       | 85 ++++++++++++++++------
>   drivers/net/ethernet/intel/ice/ice_eswitch.h       | 14 +++-
>   drivers/net/ethernet/intel/ice/ice_eswitch_br.c    |  4 +-
>   drivers/net/ethernet/intel/ice/ice_eswitch_br.h    |  1 +
>   drivers/net/ethernet/intel/ice/ice_lib.c           |  4 +-
>   drivers/net/ethernet/intel/ice/ice_main.c          | 17 ++++-
>   drivers/net/ethernet/intel/ice/ice_ptp.c           |  3 +-
>   drivers/net/ethernet/intel/ice/ice_repr.c          | 16 ++--
>   drivers/net/ethernet/intel/ice/ice_repr.h          |  1 +
>   drivers/net/ethernet/intel/ice/ice_vf_lib.c        |  2 +-
>   drivers/net/ethernet/intel/igb/Makefile            |  6 +-
>   drivers/net/ethernet/intel/igbvf/Makefile          |  6 +-
>   drivers/net/ethernet/intel/igc/Makefile            |  6 +-
>   drivers/net/ethernet/intel/igc/igc_defines.h       | 22 ++++++
>   drivers/net/ethernet/intel/igc/igc_ethtool.c       | 32 ++++++++
>   drivers/net/ethernet/intel/igc/igc_hw.h            |  2 +
>   drivers/net/ethernet/intel/igc/igc_leds.c          | 21 +-----
>   drivers/net/ethernet/intel/igc/igc_main.c          |  2 +
>   drivers/net/ethernet/intel/ixgbe/Makefile          |  8 +-
>   drivers/net/ethernet/intel/ixgbevf/Makefile        |  6 +-
>   drivers/net/ethernet/intel/libeth/Makefile         |  2 +-
>   drivers/net/ethernet/intel/libie/Makefile          |  2 +-
>   include/linux/math64.h                             | 28 +++++++
>   29 files changed, 214 insertions(+), 98 deletions(-)
> ---
> base-commit: 83042ce9b7c39b0e64094d86a70d62392ac21a06
> change-id: 20240603-next-2024-06-03-intel-next-batch-4537be19dc21
> 
> Best regards,
> --
> Jacob Keller <jacob.e.keller@...el.com>
> 
>