netdev - RE: [Intel-wired-lan] [PATCH v2 iwl-net 2/8] ice: don't busy wait for Rx queue disable in ice_qp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 4 Jun 2024 06:53:35 +0000
From: "Rout, ChandanX" <chandanx.rout@...el.com>
To: "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "Zaremba, Larysa" <larysa.zaremba@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Kubiak, Michal" <michal.kubiak@...el.com>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "Karlsson, Magnus"
	<magnus.karlsson@...el.com>, "Kuruvinakunnel, George"
	<george.kuruvinakunnel@...el.com>, "Pandey, Atul" <atul.pandey@...el.com>,
	"Nagaraju, Shwetha" <shwetha.nagaraju@...el.com>, "Pandey, Atul"
	<atul.pandey@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH v2 iwl-net 2/8] ice: don't busy wait for
 Rx queue disable in ice_qp_dis()



>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
>Fijalkowski, Maciej
>Sent: Wednesday, May 29, 2024 4:54 PM
>To: intel-wired-lan@...ts.osuosl.org
>Cc: Fijalkowski, Maciej <maciej.fijalkowski@...el.com>; Zaremba, Larysa
><larysa.zaremba@...el.com>; netdev@...r.kernel.org; Kubiak, Michal
><michal.kubiak@...el.com>; Nguyen, Anthony L
><anthony.l.nguyen@...el.com>; Karlsson, Magnus
><magnus.karlsson@...el.com>
>Subject: [Intel-wired-lan] [PATCH v2 iwl-net 2/8] ice: don't busy wait for Rx
>queue disable in ice_qp_dis()
>
>When ice driver is spammed with multiple xdpsock instances and flow control is
>enabled, there are cases when Rx queue gets stuck and unable to reflect the
>disable state in QRX_CTRL register. Similar issue has previously been addressed
>in commit 13a6233b033f ("ice: Add support to enable/disable all Rx queues
>before waiting").
>
>To workaround this, let us simply not wait for a disabled state as later patch will
>make sure that regardless of the encountered error in the process of disabling a
>queue pair, the Rx queue will be enabled.
>
>Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
>Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
>---
> drivers/net/ethernet/intel/ice/ice_xsk.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>

Tested-by: Chandan Kumar Rout <chandanx.rout@...el.com> (A Contingent Worker at Intel)