netdev - Re: [PATCH net-next] seg6: fix parameter passing when calling NF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d6a905fe4d51f4f4ea42bb19d890aa5f621d8e9c.camel@redhat.com>
Date: Tue, 04 Jun 2024 11:14:47 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jianguo Wu <wujianguo106@....com>, Pablo Neira Ayuso
 <pablo@...filter.org>
Cc: netdev <netdev@...r.kernel.org>, contact@...elbtn.com, David Ahern
	 <dsahern@...nel.org>
Subject: Re: [PATCH net-next] seg6: fix parameter passing when calling
 NF_HOOK() in End.DX4 and End.DX6 behaviors

On Tue, 2024-06-04 at 14:34 +0800, Jianguo Wu wrote:
> Hi, Pablo
> 
> On 2024/6/4 3:23, Pablo Neira Ayuso wrote:
> > Hi,
> > 
> > On Thu, May 30, 2024 at 03:43:38PM +0800, Jianguo Wu wrote:
> > > From: Jianguo Wu <wujianguo@...natelecom.cn>
> > > 
> > > input_action_end_dx4() and input_action_end_dx6() call NF_HOOK() for PREROUTING hook,
> > > for PREROUTING hook, we should passing a valid indev, and a NULL outdev to NF_HOOK(),
> > > otherwise may trigger a NULL pointer dereference, as below:
> > 
> > Could you also add a selftest to improve coverage of this infrastructure?
> > 
> 
> Sure, I will add a selftest to cover this case.

When re-submitting, please additionally target the 'net' tree,
replacing the 'net-next' prefix with 'net',

Thanks!

Paolo