[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240604092847.GO491852@kernel.org>
Date: Tue, 4 Jun 2024 10:28:47 +0100
From: Simon Horman <horms@...nel.org>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
netdev <netdev@...r.kernel.org>, Jiri Pirko <jiri@...nulli.us>,
Sergey Temerkhanov <sergey.temerkhanov@...el.com>,
Michal Michalik <michal.michalik@...el.com>,
Przemek Kitszel <przemyslaw.kitszel@...el.com>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
Karol Kolacinski <karol.kolacinski@...el.com>,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH next 07/11] ice: Introduce ETH56G PHY model for E825C
products
On Mon, Jun 03, 2024 at 12:47:42PM -0700, Jacob Keller wrote:
>
>
> On 6/1/2024 3:35 AM, Simon Horman wrote:
> > On Tue, May 28, 2024 at 04:03:57PM -0700, Jacob Keller wrote:
> >> From: Sergey Temerkhanov <sergey.temerkhanov@...el.com>
> >>
> >> E825C products feature a new PHY model - ETH56G.
> >>
> >> Introduces all necessary PHY definitions, functions etc. for ETH56G PHY,
> >> analogous to E82X and E810 ones with addition of a few HW-specific
> >> functionalities for ETH56G like one-step timestamping.
> >>
> >> It ensures correct PTP initialization and operation for E825C products.
> >>
> >> Co-developed-by: Jacob Keller <jacob.e.keller@...el.com>
> >> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> >> Co-developed-by: Michal Michalik <michal.michalik@...el.com>
> >> Signed-off-by: Michal Michalik <michal.michalik@...el.com>
> >> Signed-off-by: Sergey Temerkhanov <sergey.temerkhanov@...el.com>
> >> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> >> Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>
> >> Co-developed-by: Karol Kolacinski <karol.kolacinski@...el.com>
> >> Signed-off-by: Karol Kolacinski <karol.kolacinski@...el.com>
> >> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>
> >> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> >
> > Hi Jacob,
> >
> > This isn't a proper review, but I noticed that your signed-off
> > appears twice above.
> >
>
> Yes it does. I developed some of the original code which Sergey used
> here (hence my Co-developed-by and Signed-off-by). But I am also
> covering for Tony and submitting the patch so I added my sign-off-by to
> the end of the sequence since I'm the one who submitted the full series
> to netdev.
>
> I'm not entirely sure how to handle this, since its a bit awkward. I
> guess there are a couple of other ways we could have done this, from
> dropping my co-developed-by tag, to moving it to the end..
Thanks Jacob,
I understand the problem you face.
Perhaps you could move yourself to the bottom of the list of Co-developers,
below Tested-by. But perhaps that is worse.
No big deal on my side if you stick with what you have,
although possibly it will be flagged again (by someone else).
Powered by blists - more mailing lists