netdev - Re: [BUG] [PATCH net-next v3 0/2] netdevsim: add NAPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <708b796a-6751-4c64-9ee6-4095be0b62f2@machnikowski.net>
Date: Wed, 5 Jun 2024 13:38:42 +0200
From: Maciek Machnikowski <maciek@...hnikowski.net>
To: David Wei <dw@...idwei.uk>, Jakub Kicinski <kuba@...nel.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [BUG] [PATCH net-next v3 0/2] netdevsim: add NAPI support



On 24/04/2024 04:36, David Wei wrote:
> Add NAPI support to netdevsim and register its Rx queues with NAPI
> instances. Then add a selftest using the new netdev Python selftest
> infra to exercise the existing Netdev Netlink API, specifically the
> queue-get API.
> 
> This expands test coverage and further fleshes out netdevsim as a test
> device. It's still my goal to make it useful for testing things like
> flow steering and ZC Rx.
> 
> -----
> Changes since v2:
> * Fix null-ptr-deref on cleanup path if netdevsim is init as VF
> * Handle selftest failure if real netdev fails to change queues
> * Selftest addremove_queue test case:
>   * Skip if queues == 1
>   * Changes either combined or rx queue depending on how the netdev is
>     configured
> 
> Changes since v1:
> * Use sk_buff_head instead of a list for per-rq skb queue
> * Drop napi_schedule() if skb queue is not empty in napi poll
> * Remove netif_carrier_on() in open()
> * Remove unused page pool ptr in struct netdevsim
> * Up the netdev in NetDrvEnv automatically
> * Pass Netdev Netlink as a param instead of using globals
> * Remove unused Python imports in selftest

Hi!

This change breaks netdevsim on my setup.
Tested on Parallels ARM VM running on Mac with Fedora 40.

When using netdevsim from the latest 6.10-rc2 (and -rc1) I can't pass
any traffic (not completing any pings) nor complete
tools/testing/selftests/drivers/net/netdevsim/peer.sh test (the test
hangs at socat step trying to send anything through).

Regards
Maciek