netdev - Re: [PATCH net-next v3 1/2] net: dsa: deduplicate code adding / deleting the port address to fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 5 Jun 2024 17:15:17 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Marek Behún <kabel@...nel.org>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next v3 1/2] net: dsa: deduplicate code adding /
 deleting the port address to fdb

On Wed, Jun 05, 2024 at 03:33:28PM +0200, Marek Behún wrote:
> The sequence
>   if (dsa_switch_supports_uc_filtering(ds))
>     dsa_port_standalone_host_fdb_add(dp, addr, 0);
>   if (!ether_addr_equal(addr, conduit->dev_addr))
>     dev_uc_add(conduit, addr);
> is executed both in dsa_user_open() and dsa_user_set_mac_addr().
> 
> Its reverse is executed both in dsa_user_close() and
> dsa_user_set_mac_addr().
> 
> Refactor these sequences into new functions dsa_user_host_uc_install()
> and dsa_user_host_uc_uninstall().
> 
> Signed-off-by: Marek Behún <kabel@...nel.org>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>