[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240605161337.GA3256958-robh@kernel.org>
Date: Wed, 5 Jun 2024 10:13:37 -0600
From: Rob Herring <robh@...nel.org>
To: Conor Dooley <conor@...nel.org>
Cc: Josua Mayer <josua@...id-run.com>, Andrew Lunn <andrew@...n.ch>,
Gregory Clement <gregory.clement@...tlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Daniel Baluta <daniel.baluta@....com>,
Vinod Koul <vkoul@...nel.org>,
Kishon Vijay Abraham I <kishon@...nel.org>,
Konstantin Porotchkin <kostap@...vell.com>,
Richard Cochran <richardcochran@...il.com>,
Yazan Shhady <yazan.shhady@...id-run.com>,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
linux-phy@...ts.infradead.org, netdev@...r.kernel.org
Subject: Re: [PATCH v6 4/7] dt-bindings: phy: armada-cp110-utmi: add optional
swap-dx-lanes property
On Tue, Jun 04, 2024 at 06:41:03PM +0100, Conor Dooley wrote:
> On Sun, Jun 02, 2024 at 05:49:39PM +0200, Josua Mayer wrote:
> > Armada CP110 UTMI supports swapping D+ and D- signals.
> > usb251xb.yaml already describes a suitable device-tree property for the
> > same purpose but as child usb controller node.
> >
> > Add optional swap-dx-lanes device-tree property to armada cp110 utmi phy
> > with same semantics as usb251xb:
> > The property lists all ports that swap D+ and D-, unlisted ports are
> > considered correct.
> >
> > Signed-off-by: Josua Mayer <josua@...id-run.com>
> > ---
> > .../devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml
> > index 9ce7b4c6d208..2ef02aac042a 100644
> > --- a/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/marvell,armada-cp110-utmi-phy.yaml
> > @@ -41,6 +41,12 @@ properties:
> > Phandle to the system controller node
> > $ref: /schemas/types.yaml#/definitions/phandle
> >
> > + swap-dx-lanes:
>
> Missing a vendor prefix.
> Otherwise, to me naive eye, seems okay.
Already have the same property elsewhere, so it's fine.
>
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + description: |
>
> This | probably isn't needed though, there's not any format here that
> seems worth preserving.
>
> Thanks,
> Conor.
>
> > + Specifies the ports which will swap the differential-pair (D+/D-),
> > + default is not-swapped.
> > +
> > # Required child nodes:
> >
> > patternProperties:
> >
> > --
> > 2.35.3
> >
Powered by blists - more mailing lists