netdev - Re: [PATCH net-next] bnxt_en: fix atomic counter for ptp packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240605173540.GP791188@kernel.org>
Date: Wed, 5 Jun 2024 18:35:40 +0100
From: Simon Horman <horms@...nel.org>
To: Vadim Fedorenko <vadfed@...a.com>
Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
	Michael Chan <michael.chan@...adcom.com>,
	Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>,
	Richard Cochran <richardcochran@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bnxt_en: fix atomic counter for ptp packets

On Tue, Jun 04, 2024 at 02:19:39AM -0700, Vadim Fedorenko wrote:
> atomic_dec_if_positive returns new value regardless if it is updated or
> not. The commit in fixes changed the behavior of the condition to one
> that differs from original code. Restore original condition to properly
> maintain atomic counter.
> 
> Fixes: 165f87691a89 ("bnxt_en: add timestamping statistics support")
> Reviewed-by: Michael Chan <michael.chan@...adcom.com>
> Signed-off-by: Vadim Fedorenko <vadfed@...a.com>

Reviewed-by: Simon Horman <horms@...nel.org>