netdev - Re: [PATCH net-next 1/3] tcp: small changes in reqsk_put() and reqsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 5 Jun 2024 11:29:01 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <edumazet@...gle.com>
CC: <davem@...emloft.net>, <eric.dumazet@...il.com>, <kuba@...nel.org>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, Kuniyuki Iwashima
	<kuniyu@...zon.com>
Subject: Re: [PATCH net-next 1/3] tcp: small changes in reqsk_put() and reqsk_free()

Date: Wed,  5 Jun 2024 07:15:51 +0000
From: Eric Dumazet <edumazet@...gle.com>
> In reqsk_free(), use DEBUG_NET_WARN_ON_ONCE()
> instead of WARN_ON_ONCE() for a condition which never fired.
> 
> In reqsk_put() directly call __reqsk_free(), there is no
> point checking rsk_refcnt again right after a transition to zero.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>