netdev - Re: [PATCH net-next] inet: remove (struct uncached

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 5 Jun 2024 19:54:34 +0100
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] inet: remove (struct uncached_list)->quarantine

On Tue, Jun 04, 2024 at 04:51:50PM +0000, Eric Dumazet wrote:
> This list is used to tranfert dst that are handled by
> rt_flush_dev() and rt6_uncached_list_flush_dev() out
> of the per-cpu lists.
> 
> But quarantine list is not used later.
> 
> If we simply use list_del_init(&rt->dst.rt_uncached),
> this also removes the dst from per-cpu list.
> 
> This patch also makes the future calls to rt_del_uncached_list()
> and rt6_uncached_list_del() faster, because no spinlock
> acquisition is needed anymore.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Simon Horman <horms@...nel.org>