netdev - Re: [PATCH 2/3] net: core: Implement dstats-type stats collections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202406060345.LfJ8GAJM-lkp@intel.com>
Date: Thu, 6 Jun 2024 03:48:26 +0800
From: kernel test robot <lkp@...el.com>
To: Jeremy Kerr <jk@...econstruct.com.au>, David Ahern <dsahern@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] net: core: Implement dstats-type stats collections

Hi Jeremy,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 32f88d65f01bf6f45476d7edbe675e44fb9e1d58]

url:    https://github.com/intel-lab-lkp/linux/commits/Jeremy-Kerr/net-core-vrf-Change-pcpu_dstat-fields-to-u64_stats_t/20240605-143942
base:   32f88d65f01bf6f45476d7edbe675e44fb9e1d58
patch link:    https://lore.kernel.org/r/20240605-dstats-v1-2-1024396e1670%40codeconstruct.com.au
patch subject: [PATCH 2/3] net: core: Implement dstats-type stats collections
config: x86_64-randconfig-121-20240606 (https://download.01.org/0day-ci/archive/20240606/202406060345.LfJ8GAJM-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240606/202406060345.LfJ8GAJM-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406060345.LfJ8GAJM-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   net/core/dev.c:3379:23: sparse: sparse: incorrect type in argument 4 (different base types) @@     expected restricted __wsum [usertype] csum @@     got unsigned int @@
   net/core/dev.c:3379:23: sparse:     expected restricted __wsum [usertype] csum
   net/core/dev.c:3379:23: sparse:     got unsigned int
   net/core/dev.c:3379:23: sparse: sparse: cast from restricted __wsum
>> net/core/dev.c:10871:26: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected void const [noderef] __percpu *__vpp_verify @@     got struct pcpu_dstats const * @@
   net/core/dev.c:10871:26: sparse:     expected void const [noderef] __percpu *__vpp_verify
   net/core/dev.c:10871:26: sparse:     got struct pcpu_dstats const *
   net/core/dev.c:3819:17: sparse: sparse: context imbalance in '__dev_queue_xmit' - different lock contexts for basic block
   net/core/dev.c:5257:17: sparse: sparse: context imbalance in 'net_tx_action' - different lock contexts for basic block

vim +10871 net/core/dev.c

 10851	
 10852	/**
 10853	 *	dev_fetch_dstats - collate per-cpu network dstats statistics
 10854	 *	@s: place to store stats
 10855	 *	@dstats: per-cpu network stats to read from
 10856	 *
 10857	 *	Read per-cpu network statistics from dev->dstats and populate the
 10858	 *	related fields in @s.
 10859	 */
 10860	void dev_fetch_dstats(struct rtnl_link_stats64 *s,
 10861			      const struct pcpu_dstats __percpu *dstats)
 10862	{
 10863		int cpu;
 10864	
 10865		for_each_possible_cpu(cpu) {
 10866			u64 rx_packets, rx_bytes, rx_drops;
 10867			u64 tx_packets, tx_bytes, tx_drops;
 10868			const struct pcpu_dstats *dstats;
 10869			unsigned int start;
 10870	
 10871			dstats = per_cpu_ptr(dstats, cpu);
 10872			do {
 10873				start = u64_stats_fetch_begin(&dstats->syncp);
 10874				rx_packets = u64_stats_read(&dstats->rx_packets);
 10875				rx_bytes   = u64_stats_read(&dstats->rx_bytes);
 10876				rx_drops   = u64_stats_read(&dstats->rx_drops);
 10877				tx_packets = u64_stats_read(&dstats->tx_packets);
 10878				tx_bytes   = u64_stats_read(&dstats->tx_bytes);
 10879				tx_drops   = u64_stats_read(&dstats->tx_drops);
 10880			} while (u64_stats_fetch_retry(&dstats->syncp, start));
 10881	
 10882			s->rx_packets += rx_packets;
 10883			s->rx_bytes   += rx_bytes;
 10884			s->rx_dropped += rx_drops;
 10885			s->tx_packets += tx_packets;
 10886			s->tx_bytes   += tx_bytes;
 10887			s->tx_dropped += tx_drops;
 10888		}
 10889	}
 10890	EXPORT_SYMBOL_GPL(dev_fetch_dstats);
 10891	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki