netdev - Re: [PATCH net-next] net: allow rps/rfs related configs to be switched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240605195403.GZ791188@kernel.org>
Date: Wed, 5 Jun 2024 20:54:03 +0100
From: Simon Horman <horms@...nel.org>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	davem@...emloft.net, dsahern@...nel.org, netdev@...r.kernel.org,
	Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next] net: allow rps/rfs related configs to be
 switched

On Wed, Jun 05, 2024 at 08:54:03AM +0800, Jason Xing wrote:
> Hello Simon,
> 
> On Wed, Jun 5, 2024 at 1:04 AM Simon Horman <horms@...nel.org> wrote:
> >
> > On Sat, Jun 01, 2024 at 12:44:40AM +0800, Jason Xing wrote:
> > > From: Jason Xing <kernelxing@...cent.com>
> > >
> > > After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL
> > > is off, I found that I cannot easily enable/disable the config
> > > because of lack of the prompt when using 'make menuconfig'. Therefore,
> > > I decided to change rps/rfc related configs altogether.
> > >
> > > Signed-off-by: Jason Xing <kernelxing@...cent.com>
> >
> > Hi Jason,
> >
> > FWIIW, I think it would be appropriate to also add help text for each option.
> > And I would drop "Enable", modeling Kdoc on, f.e. CONFIG_CGROUP_NET_CLASSID.
> 
> Thanks for your review.
> 
> I will adjust as you suggest in the next submission.

Thanks.

> > Likewise for CONFIG_BQL, although that isn't strictly related to this
> > patch.
> 
> Yes, I can see. I think I could write another patch to do this since
> currently I would like to submit a rps/rfs related patch.

Yes, of course.
It's a separate issue.