netdev - Re: [PATCH 0/9] Intel Wired LAN Driver Updates 2024-06-03

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <735233d0-b462-4669-aaff-e7fb3213f251@intel.com>
Date: Wed, 5 Jun 2024 13:38:34 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>, Jakub
 Kicinski <kuba@...nel.org>
CC: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Aleksandr Loktionov
	<aleksandr.loktionov@...el.com>, Alexander Lobakin
	<aleksander.lobakin@...el.com>, Pucha Himasekhar Reddy
	<himasekharx.reddy.pucha@...el.com>, Michal Swiatkowski
	<michal.swiatkowski@...ux.intel.com>, Wojciech Drewek
	<wojciech.drewek@...el.com>, Sujai Buvaneswaran
	<sujai.buvaneswaran@...el.com>, Michal Schmidt <mschmidt@...hat.com>, "Sunil
 Goutham" <sgoutham@...vell.com>, Eric Joyner <eric.joyner@...el.com>, Przemek
 Kitszel <przemyslaw.kitszel@...el.com>, Karen Ostrowska
	<karen.ostrowska@...el.com>, Vitaly Lifshits <vitaly.lifshits@...el.com>,
	Menachem Fogel <menachem.fogel@...el.com>, Naama Meir
	<naamax.meir@...ux.intel.com>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH 0/9] Intel Wired LAN Driver Updates 2024-06-03



On 6/3/2024 3:38 PM, Jacob Keller wrote:
> This series includes miscellaneous improvements for the ice and igc, as
> well as a cleanup to the Makefiles for all Intel net drivers.
> 
> Andy fixes all of the Intel net driver Makefiles to use the documented
> '*-y' syntax for specifying object files to link into kernel driver
> modules, rather than the '*-objs' syntax which works but is documented as
> reserved for user-space host programs.
> 
> Michal Swiatkowski has four patches to prepare the ice driver for
> supporting subfunctions. This includes some cleanups to the locking around
> devlink port creation as well as improvements to the driver's handling of
> port representor VSIs.
> 
> Jacob has a cleanup to refactor rounding logic in the ice driver into a
> common roundup_u64 helper function.
> 
> Michal Schmidt replaces irq_set_affinity_hint() to use
> irq_update_affinity_hint() which behaves better with user-applied affinity
> settings.
> 
> Eric improves checks to the ice_vsi_rebuild() function, checking and
> reporting failures when the function is called during a reset.
> 
> Vitaly adds support for ethtool .set_phys_id, used for blinking the device
> LEDs to identify the physical port for which a device is connected to.
> 
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>

The igc patch needs to be completely removed and reworked. I think I
also saw some comments about Eric's ice_vsi_rebuild() that we missed on
Intel Wired LAN.

> https://lore.kernel.org/intel-wired-lan/20240604144712.GR491852@kernel.org/

I'm going to send a v2 which drops those two patches so that they can be
reworked.

Thanks,
Jake