[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4e7a80f7-d650-4deb-b331-b9de7951cfa1@gmail.com>
Date: Wed, 5 Jun 2024 08:14:10 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Aleksandr Mishin <amishin@...rgos.ru>, Mark Bloch <mbloch@...dia.com>
Cc: Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
Tariq Toukan <tariqt@...dia.com>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Maor Gottlieb <maorg@...dia.com>,
Jacob Keller <jacob.e.keller@...el.com>, Shay Drory <shayd@...dia.com>,
Jianbo Liu <jianbol@...dia.com>, Jinjie Ruan <ruanjinjie@...wei.com>,
netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH net] net/mlx5: Fix tainted pointer delete is case of flow
rules creation fail
On 04/06/2024 13:05, Aleksandr Mishin wrote:
> In case of flow rule creation fail in mlx5_lag_create_port_sel_table(),
> instead of previously created rules, the tainted pointer is deleted
> deveral times.
> Fix this bug by using correct flow rules pointers.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 352899f384d4 ("net/mlx5: Lag, use buckets in hash mode")
> Signed-off-by: Aleksandr Mishin <amishin@...rgos.ru>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c
> index c16b462ddedf..ab2717012b79 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/port_sel.c
> @@ -88,9 +88,13 @@ static int mlx5_lag_create_port_sel_table(struct mlx5_lag *ldev,
> &dest, 1);
> if (IS_ERR(lag_definer->rules[idx])) {
> err = PTR_ERR(lag_definer->rules[idx]);
> - while (i--)
> - while (j--)
> + do {
> + while (j--) {
> + idx = i * ldev->buckets + j;
> mlx5_del_flow_rules(lag_definer->rules[idx]);
> + }
> + j = ldev->buckets;
> + } while (i--);
> goto destroy_fg;
> }
> }
Reviewed-by: Tariq Toukan <tariqt@...dia.com>
Thanks.
Powered by blists - more mailing lists