netdev - Re: [PATCH net 2/2] net: hns3: add cond_resched() to hns3 ring buffer init process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240606162714.GN791188@kernel.org>
Date: Thu, 6 Jun 2024 17:27:14 +0100
From: Simon Horman <horms@...nel.org>
To: Jijie Shao <shaojijie@...wei.com>
Cc: yisen.zhuang@...wei.com, salil.mehta@...wei.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	shenjian15@...wei.com, wangjie125@...wei.com,
	liuyonglong@...wei.com, chenhao418@...wei.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 2/2] net: hns3: add cond_resched() to hns3 ring
 buffer init process

On Wed, Jun 05, 2024 at 03:20:58PM +0800, Jijie Shao wrote:
> From: Jie Wang <wangjie125@...wei.com>
> 
> Currently hns3 ring buffer init process would hold cpu too long with big
> Tx/Rx ring depth. This could cause soft lockup.
> 
> So this patch adds cond_resched() to the process. Then cpu can break to
> run other tasks instead of busy looping.
> 
> Fixes: a723fb8efe29 ("net: hns3: refine for set ring parameters")
> Signed-off-by: Jie Wang <wangjie125@...wei.com>
> Signed-off-by: Jijie Shao <shaojijie@...wei.com>

Reviewed-by: Simon Horman <horms@...nel.org>