netdev - Re: [PATCH net-next v2 0/3] net: core: Unify dstats with tstats and lstats, add generic collection helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fec284041a4a4ccc450fdfd504aae4f24458b79c.camel@codeconstruct.com.au>
Date: Thu, 06 Jun 2024 11:01:01 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Jakub Kicinski <kuba@...nel.org>
Cc: David Ahern <dsahern@...nel.org>, "David S. Miller"
 <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/3] net: core: Unify dstats with tstats and
 lstats, add generic collection helper

Hi Jakub,

> > If we're not exporting the helpers, that means that drivers that
> > use
> > dstats wouldn't have a facility to customise the stats collection
> > through a ndo_get_stats64() callback though (as can be done with
> > tstats). Are you ok with that?
> > 
> > [the set of drivers that need that is currently zero, so more of a
> > hypothetical future problem...]
> 
> Right, but I think "no exports unless there is an in-tree user"
> is still a rule. A bit of a risk that someone will roll their own
> per-cpu stats pointlessly if we lack this export. But let's try
> to catch that in review..

OK, sounds good! I'll send a v3 shortly.

Cheers,

Jeremy