netdev - RE: [PATCH net] devlink: Fix setting max_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 6 Jun 2024 04:40:43 +0000
From: Parav Pandit <parav@...dia.com>
To: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "dsahern@...nel.org"
	<dsahern@...nel.org>, "stephen@...workplumber.org"
	<stephen@...workplumber.org>
CC: Jiri Pirko <jiri@...dia.com>, Shay Drori <shayd@...dia.com>
Subject: RE: [PATCH net] devlink: Fix setting max_io_eqs as the sole attribute



> From: Parav Pandit <parav@...dia.com>
> Sent: Thursday, June 6, 2024 10:08 AM
> To: netdev@...r.kernel.org; dsahern@...nel.org;
> stephen@...workplumber.org
> Cc: Jiri Pirko <jiri@...dia.com>; Shay Drori <shayd@...dia.com>; Parav
> Pandit <parav@...dia.com>
> Subject: [PATCH net] devlink: Fix setting max_io_eqs as the sole attribute
>
I missed to include iproute2 in the subject prefix. :(
Will avoid this mistake next time.
 
> dl_opts_put() function missed to consider IO eqs option flag.
> Due to this, when max_io_eqs setting is applied only when it is combined
> with other attributes such as roce/hw_addr.
> When max_io_eqs is the only attribute set, it missed to apply the attribute.
> 
> Fix it by adding the missing flag.
> 
> Fixes: e8add23c59b7 ("devlink: Support setting max_io_eqs")
> Signed-off-by: Parav Pandit <parav@...dia.com>
> ---
>  devlink/devlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/devlink/devlink.c b/devlink/devlink.c index 03d27202..3ab5a85d
> 100644
> --- a/devlink/devlink.c
> +++ b/devlink/devlink.c
> @@ -2637,7 +2637,7 @@ static void dl_opts_put(struct nlmsghdr *nlh,
> struct dl *dl)
>  		mnl_attr_put_u64(nlh,
> DEVLINK_ATTR_TRAP_POLICER_BURST,
>  				 opts->trap_policer_burst);
>  	if (opts->present & (DL_OPT_PORT_FUNCTION_HW_ADDR |
> DL_OPT_PORT_FUNCTION_STATE |
> -			     DL_OPT_PORT_FN_CAPS))
> +			     DL_OPT_PORT_FN_CAPS |
> DL_OPT_PORT_FN_MAX_IO_EQS))
>  		dl_function_attr_put(nlh, opts);
>  	if (opts->present & DL_OPT_PORT_FLAVOUR)
>  		mnl_attr_put_u16(nlh, DEVLINK_ATTR_PORT_FLAVOUR,
> opts->port_flavour);
> --
> 2.26.2