netdev - Re: [PATCH net-next v3 4/4] dt-bindings: net: cdns,macb: Deprecate magic-packet property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 6 Jun 2024 08:17:12 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Vineeth Karumanchi <vineeth.karumanchi@....com>,
 Rob Herring <robh@...nel.org>
Cc: nicolas.ferre@...rochip.com, claudiu.beznea@...on.dev,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 linux@...linux.org.uk, vadim.fedorenko@...ux.dev, andrew@...n.ch,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, git@....com
Subject: Re: [PATCH net-next v3 4/4] dt-bindings: net: cdns,macb: Deprecate
 magic-packet property

On 06/06/2024 07:13, Vineeth Karumanchi wrote:
> Hi Rob,
> 
> 
> On 05/06/24 9:11 pm, Rob Herring wrote:
>> On Wed, Jun 05, 2024 at 03:54:57PM +0530, Vineeth Karumanchi wrote:
>>> WOL modes such as magic-packet should be an OS policy.
>>> By default, advertise supported modes and use ethtool to activate
>>> the required mode.
>>>
>>> Suggested-by: Andrew Lunn <andrew@...n.ch>
>>> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@....com>
>>> ---
>>>   Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
>>>   1 file changed, 1 insertion(+)
>>
>> You forgot Krzysztof's ack.
>>
> 
> There is a change in the commit message from earlier version,
> as we are not using caps any more, I thought of not including the ack.
> 
> I will add his ack in next version.

And where is it mentioned that you drop someone's ack on purpose?

Best regards,
Krzysztof