netdev - Re: [PATCH net v3] liquidio: Adjust a NULL pointer handling path in lio_vf_rep_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 07 Jun 2024 13:32:43 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Aleksandr Mishin <amishin@...rgos.ru>
Cc: davem@...emloft.net, horms@...nel.org, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, keescook@...omium.org,
 justinstitt@...gle.com, felix.manlunas@...ium.com,
 satananda.burla@...ium.com, raghu.vatsavayi@...ium.com,
 vijaya.guvva@...ium.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH net v3] liquidio: Adjust a NULL pointer handling path in
 lio_vf_rep_copy_packet

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@...emloft.net>:

On Wed, 5 Jun 2024 13:11:35 +0300 you wrote:
> In lio_vf_rep_copy_packet() pg_info->page is compared to a NULL value,
> but then it is unconditionally passed to skb_add_rx_frag() which looks
> strange and could lead to null pointer dereference.
> 
> lio_vf_rep_copy_packet() call trace looks like:
> 	octeon_droq_process_packets
> 	 octeon_droq_fast_process_packets
> 	  octeon_droq_dispatch_pkt
> 	   octeon_create_recv_info
> 	    ...search in the dispatch_list...
> 	     ->disp_fn(rdisp->rinfo, ...)
> 	      lio_vf_rep_pkt_recv(struct octeon_recv_info *recv_info, ...)
> In this path there is no code which sets pg_info->page to NULL.
> So this check looks unneeded and doesn't solve potential problem.
> But I guess the author had reason to add a check and I have no such card
> and can't do real test.
> In addition, the code in the function liquidio_push_packet() in
> liquidio/lio_core.c does exactly the same.
> 
> [...]

Here is the summary with links:
  - [net,v3] liquidio: Adjust a NULL pointer handling path in lio_vf_rep_copy_packet
    https://git.kernel.org/netdev/net/c/c44711b78608

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html