netdev - Re: [PATCH net-next 11/13] net: dsa: lantiq_gswip: Fix comments in gswip_port_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 07 Jun 2024 15:43:22 +0200
From: Martin Schiller <ms@....tdt.de>
To: Vladimir Oltean <olteanv@...il.com>
Cc: martin.blumenstingl@...glemail.com, hauke@...ke-m.de, andrew@...n.ch,
 f.fainelli@...il.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 11/13] net: dsa: lantiq_gswip: Fix comments in
 gswip_port_vlan_filtering()

On 2024-06-07 13:44, Vladimir Oltean wrote:
> On Thu, Jun 06, 2024 at 10:52:32AM +0200, Martin Schiller wrote:
>> From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
>> 
>> Update the comments in gswip_port_vlan_filtering() so it's clear that
>> there are two separate cases, one for "tag based VLAN" and another one
>> for "port based VLAN".
>> 
>> Suggested-by: Martin Schiller <ms@....tdt.de>
>> Signed-off-by: Martin Blumenstingl 
>> <martin.blumenstingl@...glemail.com>
>> ---
> 
> Here and in whatever the previous patch turns into: please make more
> careful use of the word "fix". It carries connotations of addressing
> bugs which must be backported. Various automated tools scan the git 
> tree
> for bug fixes which were apparently "not properly submitted" and mark
> them for auto-selection to stable. You don't want to cause that for a
> minor comment.

OK, I will eliminate the term "fix" wherever it is not appropriate.