netdev - Re: [PATCH net] bnxt_en: Cap the size of HWRM_PORT_PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240607135046.GD27689@kernel.org>
Date: Fri, 7 Jun 2024 14:50:46 +0100
From: Simon Horman <horms@...nel.org>
To: Michael Chan <michael.chan@...adcom.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, andrew.gospodarek@...adcom.com,
	Somnath Kotur <somnath.kotur@...adcom.com>,
	Pavan Chebbi <pavan.chebbi@...adcom.com>
Subject: Re: [PATCH net] bnxt_en: Cap the size of HWRM_PORT_PHY_QCFG
 forwarded response

On Thu, Jun 06, 2024 at 10:51:07AM -0700, Michael Chan wrote:
> Firmware interface 1.10.2.118 has increased the size of
> HWRM_PORT_PHY_QCFG response beyond the maximum size that can be
> forwarded.  When the VF's link state is not the default auto state,
> the PF will need to forward the response back to the VF to indicate
> the forced state.  This regression may cause the VF to fail to
> initialize.
> 
> Fix it by capping the HWRM_PORT_PHY_QCFG response to the maximum
> 96 bytes.  Also modify bnxt_hwrm_fwd_resp() to print a warning if the
> message size exceeds 96 bytes to make this failure more obvious.
> 
> Bug: DCSG01725771
> Change-Id: I4cd5e06a7625f9d06e779e4acd9603d355883e7c

Hi Michael,

Does the above relate to publicly available information?
If so, a link is probably in order. If not, let's drop it.

> Fixes: 84a911db8305 ("bnxt_en: Update firmware interface to 1.10.2.118")
> Reviewed-by: Somnath Kotur <somnath.kotur@...adcom.com>
> Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>

...

> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c

...

> @@ -1096,6 +1099,8 @@ static int bnxt_vf_set_link(struct bnxt *bp, struct bnxt_vf_info *vf)
>  		mutex_unlock(&bp->link_lock);
>  		phy_qcfg_resp.resp_len = cpu_to_le16(sizeof(phy_qcfg_resp));
>  		phy_qcfg_resp.seq_id = phy_qcfg_req->seq_id;
> +		phy_qcfg_resp.option_flags &=
> +			~PORT_PHY_QCAPS_RESP_FLAGS2_SPEEDS2_SUPPORTED;

I may be missing something obvious, but it is not clear to me
how this change relates to the rest of the patch.

>  		phy_qcfg_resp.valid = 1;
>  
>  		if (vf->flags & BNXT_VF_LINK_UP) {
> -- 
> 2.30.1
>