netdev - Re: [PATCH net] net/sched: Fix mirred deadlock on device recursion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18ecd075c0c0d32a2b854b470155880d58bef082.camel@sipsolutions.net>
Date: Fri, 07 Jun 2024 16:56:49 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Eric Dumazet <edumazet@...gle.com>
Cc: Victor Nogueira <victor@...atatu.com>, davem@...emloft.net,
 kuba@...nel.org,  pabeni@...hat.com, jhs@...atatu.com, jiri@...nulli.us,
 xiyou.wangcong@...il.com,  netdev@...r.kernel.org, renmingshuai@...wei.com,
 pctammela@...atatu.com
Subject: Re: [PATCH net] net/sched: Fix mirred deadlock on device recursion

On Fri, 2024-06-07 at 16:54 +0200, Eric Dumazet wrote:
> > 
> > I'm not sure I understand the busylock logic well enough

> Why not simply initialize noop_qdisc.owner to -1 ?

I didn't understand the locking logic, so I was worried you could still
have it be used in parallel since it can be assigned to any number of
devices.

johannes