netdev - Re: [PATCH] net/sched: initialize noop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <541b6a89-bd1c-4e7f-a694-392649dbd778@gmail.com>
Date: Sat, 8 Jun 2024 10:05:12 +0200
From: Eric Dumazet <eric.dumazet@...il.com>
To: Johannes Berg <johannes@...solutions.net>, netdev@...r.kernel.org
Cc: Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCH] net/sched: initialize noop_qdisc owner


On 6/7/24 17:53, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@...el.com>
>
> When the noop_qdisc owner isn't initialized, then it will be 0,
> so packets will erroneously be regarded as having been subject
> to recursion as long as only CPU 0 queues them. For non-SMP,
> that's all packets, of course. This causes a change in what's
> reported to userspace, normally noop_qdisc would drop packets
> silently, but with this change the syscall returns -ENOBUFS if
> RECVERR is also set on the socket.
>
> Fix this by initializing the owner field to -1, just like it
> would be for dynamically allocated qdiscs by qdisc_alloc().
>
> Fixes: 0f022d32c3ec ("net/sched: Fix mirred deadlock on device recursion")
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>


I found this quite by luck.

Please CC maintainers next time, and blamed patch authors :/

Believe it or not, I do not follow netdev@ traffic.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks.