netdev - Re: [PATCH wifi-next 2/2] wifi: mac80211: Remove generic .ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sat, 8 Jun 2024 09:59:17 +0100
From: Simon Horman <horms@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: kvalo@...nel.org, linux-wireless@...r.kernel.org,
	Johannes Berg <johannes@...solutions.net>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	sbhatta@...vell.com,
	"open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH wifi-next 2/2] wifi: mac80211: Remove generic
 .ndo_get_stats64

On Fri, Jun 07, 2024 at 03:20:44AM -0700, Breno Leitao wrote:
> Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
> configured") moved the callback to dev_get_tstats64() to net core, so,
> unless the driver is doing some custom stats collection, it does not
> need to set .ndo_get_stats64.
> 
> Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
> doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
> function pointer.
> 
> In this driver specifically, .ndo_get_stats64 basically points to
> dev_fetch_sw_netstats(). Now it will point to dev_get_tstats64(), which
> calls netdev_stats_to_stats64() and dev_fetch_sw_netstats().
> netdev_stats_to_stats64() seems irrelevant for this driver.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Reviewed-by: Simon Horman <horms@...nel.org>