netdev - Re: [PATCH v2 net] ptp: ocp: adjust serial port symlink creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZmQt_6DaGFXbagSB@surfacebook.localdomain>
Date: Sat, 8 Jun 2024 13:10:07 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jakub Kicinski <kuba@...nel.org>, Jiri Slaby <jirislaby@...nel.org>,
	Jonathan Lemon <jonathan.lemon@...il.com>,
	linux-serial@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] ptp: ocp: adjust serial port symlink creation

Fri, May 10, 2024 at 11:04:05AM +0000, Vadim Fedorenko kirjoitti:
> The commit b286f4e87e32 ("serial: core: Move tty and serdev to be children
> of serial core port device") changed the hierarchy of serial port devices
> and device_find_child_by_name cannot find ttyS* devices because they are
> no longer directly attached. Add some logic to restore symlinks creation
> to the driver for OCP TimeCard.

I know that I'm a bit late to the party, but this patch looks like an ugly
hack. The PTP OCP code, in my opinion, needs a lot of love besides the UART
part.

-- 
With Best Regards,
Andy Shevchenko