Date: Sun, 9 Jun 2024 11:10:54 +0200
From: Hans-Frieder Vogt <hfdevel@....net>
To: FUJITA Tomonori <fujita.tomonori@...il.com>, netdev@...r.kernel.org
Cc: andrew@...n.ch, horms@...nel.org, kuba@...nel.org, jiri@...nulli.us,
 pabeni@...hat.com, linux@...linux.org.uk, naveenm@...vell.com,
 jdamato@...tly.com
Subject: Re: [PATCH net-next v9 0/6] add ethernet driver for Tehuti Networks
 TN40xx chips

On 06.06.2024 01.26, FUJITA Tomonori wrote:

> This patchset adds a new 10G ethernet driver for Tehuti Networks
> TN40xx chips. Note in mainline, there is a driver for Tehuti Networks
> (drivers/net/ethernet/tehuti/tehuti.[hc]), which supports TN30xx
> chips.
>
> Multiple vendors (DLink, Asus, Edimax, QNAP, etc) developed adapters
> based on TN40xx chips. Tehuti Networks went out of business but the
> drivers are still distributed under GPL2 with some of the hardware
> (and also available on some sites). With some changes, I try to
> upstream this driver with a new PHY driver in Rust.
>
> The major change is replacing the PHY abstraction layer in the original
> driver with phylink. TN40xx chips are used with various PHY hardware
> (AMCC QT2025, TI TLK10232, Aqrate AQR105, and Marvell MV88X3120,
> MV88X3310, and MV88E2010).
>
> I've also been working on a new PHY driver for QT2025 in Rust [1]. For
> now, I enable only adapters using QT2025 PHY in the PCI ID table of
> this driver. I've tested this driver and the QT2025 PHY driver with
> Edimax EN-9320 10G adapter and 10G-SR SFP+. In mainline, there are PHY
> drivers for AQR105 and Marvell PHYs, which could work for some TN40xx
> adapters with this driver.
>
> To make reviewing easier, this patchset has only basic functions. Once
> merged, I'll submit features like ethtool support.
>
> v9:
> - move phylink_connect_phy() to simplify the ndo_open callback
> v8: https://lore.kernel.org/netdev/20240603064955.58327-1-fujita.tomonori@gmail.com/
> - remove phylink_mac_change() call
> - fix phylink_start() usage (call it after the driver is ready to operate).
> - simplify the way to get the private struct from phylink_config pointer
> - fix netif_stop_queue usage in mac_link_down callback
> - remove MLO_AN_PHY usage
> v7: https://lore.kernel.org/netdev/20240527203928.38206-7-fujita.tomonori@gmail.com/
> - use page pool API for rx allocation
> - fix NAPI API misuse
> - fix error checking of mdio write
> v6: https://lore.kernel.org/netdev/20240512085611.79747-2-fujita.tomonori@gmail.com/
> - use the firmware for TN30xx chips
> - move link up/down code to phylink's mac_link_up/mac_link_down callbacks
> - clean up mdio access code
> v5: https://lore.kernel.org/netdev/20240508113947.68530-1-fujita.tomonori@gmail.com/
> - remove dma_set_mask_and_coherent fallback
> - count tx_dropped
> - use ndo_get_stats64 instead of ndo_get_stats
> - remove unnecessary __packed attribute
> - fix NAPI API usage
> - rename tn40_recycle_skb to tn40_recycle_rx_buffer
> - avoid high order page allocation (the maximum is order-1 now)
> v4: https://lore.kernel.org/netdev/20240501230552.53185-1-fujita.tomonori@gmail.com/
> - fix warning on 32bit build
> - fix inline warnings
> - fix header file inclusion
> - fix TN40_NDEV_TXQ_LEN
> - remove 'select PHYLIB' in Kconfig
> - fix access to phydev
> - clean up readx_poll_timeout_atomic usage
> v3: https://lore.kernel.org/netdev/20240429043827.44407-1-fujita.tomonori@gmail.com/
> - remove driver version
> - use prefixes tn40_/TN40_ for all function, struct and define names
> v2: https://lore.kernel.org/netdev/20240425010354.32605-1-fujita.tomonori@gmail.com/
> - split mdio patch into mdio and phy support
> - add phylink support
> - clean up mdio read/write
> - use the standard bit operation macros
> - use upper_32/lower_32_bits macro
> - use tn40_ prefix instead of bdx_
> - fix Sparse errors
> - fix compiler warnings
> - fix style issues
> v1: https://lore.kernel.org/netdev/20240415104352.4685-1-fujita.tomonori@gmail.com/
>
> [1] https://lore.kernel.org/netdev/20240415104701.4772-1-fujita.tomonori@gmail.com/
>
> FUJITA Tomonori (6):
>    net: tn40xx: add pci driver for Tehuti Networks TN40xx chips
>    net: tn40xx: add register defines
>    net: tn40xx: add basic Tx handling
>    net: tn40xx: add basic Rx handling
>    net: tn40xx: add mdio bus support
>    net: tn40xx: add phylink support
>
>   MAINTAINERS                             |    8 +-
>   drivers/net/ethernet/tehuti/Kconfig     |   15 +
>   drivers/net/ethernet/tehuti/Makefile    |    3 +
>   drivers/net/ethernet/tehuti/tn40.c      | 1771 +++++++++++++++++++++++
>   drivers/net/ethernet/tehuti/tn40.h      |  233 +++
>   drivers/net/ethernet/tehuti/tn40_mdio.c |  143 ++
>   drivers/net/ethernet/tehuti/tn40_phy.c  |   76 +
>   drivers/net/ethernet/tehuti/tn40_regs.h |  245 ++++
>   8 files changed, 2493 insertions(+), 1 deletion(-)
>   create mode 100644 drivers/net/ethernet/tehuti/tn40.c
>   create mode 100644 drivers/net/ethernet/tehuti/tn40.h
>   create mode 100644 drivers/net/ethernet/tehuti/tn40_mdio.c
>   create mode 100644 drivers/net/ethernet/tehuti/tn40_phy.c
>   create mode 100644 drivers/net/ethernet/tehuti/tn40_regs.h
>
>
> base-commit: c790275b5edf5d8280ae520bda7c1f37da460c00

Hi Tomonori,

feel free to add my

Reviewed-by: Hans-Frieder Vogt <hfdevel@....net>

to your patch series.
I have also tested your driver, however since I have 10GBASE-T cards
with x3310 and aqr105 phys I had to add a few lines (very few!) to make
them work. Therefore, formally I cannot claim to have tested exactly
your patches.
Once your driver is out, I will post patches for supporting the other phys.
Thanks for taking the effort of mainlining this driver!
Best regards,
Hans

Powered by blists - more mailing lists