netdev - Re: [PATCH net-next v9 5/6] net: tn40xx: add mdio bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240610.210547.418635399210812330.fujita.tomonori@gmail.com>
Date: Mon, 10 Jun 2024 21:05:47 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: linux@...linux.org.uk
Cc: fujita.tomonori@...il.com, netdev@...r.kernel.org, andrew@...n.ch,
 horms@...nel.org, kuba@...nel.org, jiri@...nulli.us, pabeni@...hat.com,
 hfdevel@....net, naveenm@...vell.com, jdamato@...tly.com
Subject: Re: [PATCH net-next v9 5/6] net: tn40xx: add mdio bus support

On Mon, 10 Jun 2024 11:04:54 +0100
"Russell King (Oracle)" <linux@...linux.org.uk> wrote:

> On Thu, Jun 06, 2024 at 08:26:07AM +0900, FUJITA Tomonori wrote:
>> +static int tn40_mdio_get(struct tn40_priv *priv, u32 *val)
> 
> I think this would be better named "tn40_mdio_wait_nonbusy()" because
> that seems to be this function's primary purpose.

Surely, sounds much better. I'll rename.

>> +static int tn40_mdio_read_cb(struct mii_bus *mii_bus, int addr, int devnum,
>> +			     int regnum)
>> +static int tn40_mdio_write_cb(struct mii_bus *mii_bus, int addr, int devnum,
>> +			      int regnum, u16 val)
> 
> I think it would be better to name these both with a _c45 suffix (which
> tells us that they're clause 45 accessors) rather than using _cb
> (presumably for callback which tells us nothing!)

Indeed. I'll use tn40_mdio_read_c45/tn40_mdio_write_c45 names in
v10. I felt that _cb was meaningless but I couldn't come up with good
names.

Thanks!