netdev - Re: [PATCH net-next v3 0/3] net: core: Unify dstats with tstats and lstats, implement generic dstats collection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea309c08-4726-430c-a9c5-295e76ba61d4@kernel.org>
Date: Mon, 10 Jun 2024 09:19:12 -0600
From: David Ahern <dsahern@...nel.org>
To: Jeremy Kerr <jk@...econstruct.com.au>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 0/3] net: core: Unify dstats with tstats and
 lstats, implement generic dstats collection

On 6/7/24 4:25 AM, Jeremy Kerr wrote:
> The struct pcpu_dstats ("dstats") has a few variations from the other
> two stats types (struct pcpu_sw_netstats and struct pcpu_lstats), and
> doesn't have generic helpers for collecting the per-cpu stats into a
> struct rtnl_link_stats64.
> 
> This change unifies dstats with the other types, adds a collection
> implementation to the core, and updates the single driver (vrf) to use
> this generic implementation.
> 
> Of course, questions/comments/etc are most welcome!
> 
> Signed-off-by: Jeremy Kerr <jk@...econstruct.com.au>
> ---
> v3:
> - rather than exposing helpers, perform dstat collection implicitly when
>   type == NETDEV_PCPU_STAT_DSTAT
> - Link to v2:
>   https://lore.kernel.org/r/20240605-dstats-v2-0-7fae03f813f3@codeconstruct.com.au
> 
> ---
> v2:
> - use correct percpu var in dev_fetch_dstats
> - use correct accessor in vfr rx drop accounting
> - v1: https://lore.kernel.org/r/20240605-dstats-v1-0-1024396e1670@codeconstruct.com.au
> 
> ---
> Jeremy Kerr (3):
>       net: core,vrf: Change pcpu_dstat fields to u64_stats_t
>       net: core: Implement dstats-type stats collections
>       net: vrf: move to generic dstat helpers
> 
>  drivers/net/vrf.c         | 56 ++++++++++++++---------------------------------
>  include/linux/netdevice.h | 12 +++++-----
>  net/core/dev.c            | 50 ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 73 insertions(+), 45 deletions(-)
> ---
> base-commit: 32f88d65f01bf6f45476d7edbe675e44fb9e1d58
> change-id: 20240605-dstats-b6e08c318555
> 
> Best regards,

For the set:
Reviewed-by: David Ahern <dsahern@...nel.org>

thanks