netdev - Re: Re: [PATCH] net: phy: rtl8211f add ethtool set wol function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5fe08f6-6aad-4b64-8925-8f8ae1b26482@lunn.ch>
Date: Mon, 10 Jun 2024 18:46:02 +0200
From: Andrew Lunn <andrew@...n.ch>
To: yangfeng <yangfeng59949@....com>
Cc: netdev@...r.kernel.org
Subject: Re: Re: [PATCH] net: phy: rtl8211f add ethtool set wol function

On Tue, Jun 11, 2024 at 12:38:55AM +0800, yangfeng wrote:
> And use the PMEB mode magic package for wol, however INTB mode can't
> be specified this way.

Please explain in detail what you mean. Why cannot INTB be used?

> Also, the PMEB mode register is not set in this code, the board is
> set to PMEB mode via bios.

Linux should not trust external code. What happens when somebody else
uses this PHY, say on an ARM system, and uboot does not set PMEB? If
your board only works with PMEB, then set it to PMEB. That makes it
clear to other developers that want to use INTB they need to be
careful not to break your code which then explicitly sets it to PMEB.

     Andrew