netdev - Re: [PATCH net-next v9 3/6] net: tn40xx: add basic Tx handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240611.060250.2237029167355751325.fujita.tomonori@gmail.com>
Date: Tue, 11 Jun 2024 06:02:50 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: hfdevel@....net, fujita.tomonori@...il.com
Cc: andrew@...n.ch, horms@...nel.org, kuba@...nel.org, jiri@...nulli.us,
 pabeni@...hat.com, linux@...linux.org.uk, naveenm@...vell.com,
 jdamato@...tly.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v9 3/6] net: tn40xx: add basic Tx handling

On Mon, 10 Jun 2024 15:48:50 +0900 (JST)
FUJITA Tomonori <fujita.tomonori@...il.com> wrote:

> On Sun, 9 Jun 2024 13:41:20 +0200
> Hans-Frieder Vogt <hfdevel@....net> wrote:
> 
>>> +static int tn40_priv_init(struct tn40_priv *priv)
>>> +{
>>> +	int ret;
>>> +
>>> +	tn40_set_link_speed(priv, 0);
>>> +
>>> +	ret = tn40_hw_reset(priv);
>>> +	if (ret)
>>> +		return ret;
>>> +
>>> +	/* Set GPIO[9:0] to output 0 */
>>> + tn40_write_reg(priv, 0x51E0, 0x30010006); /* GPIO_OE_ WR CMD */
>>> +	tn40_write_reg(priv, 0x51F0, 0x0);	/* GPIO_OE_ DATA */
>>> +	tn40_write_reg(priv, TN40_REG_MDIO_CMD_STAT, 0x3ec8);
>> 
>> the last tn40_write_reg (to TN40_REG_MDIO_CMD_STAT) is in fact the
>> same as:
>> 
>> tn40_mdio_set_speed(priv, TN40_MDIO_SPEED_1MHZ);
> 
> This means that as the original driver does, this driver sets bus
> speed to 6MHZ for QT2025 PHY, however after that, this driver sets
> it to 1MHZ again?

This overwriting doesn't make sense and seems that the NIC works well
without the above line. I'll drop it in v10.