netdev - Re: [PATCH net-next v2 3/8] netlink: specs: Expand the PSE netlink command with C33 new features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240610113939.41d86109@kmaincent-XPS-13-7390>
Date: Mon, 10 Jun 2024 11:39:39 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Donald Hunter <donald.hunter@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Oleksij Rempel <o.rempel@...gutronix.de>, Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, Dent Project <dentproject@...uxfoundation.org>,
 kernel@...gutronix.de
Subject: Re: [PATCH net-next v2 3/8] netlink: specs: Expand the PSE netlink
 command with C33 new features

On Fri, 07 Jun 2024 11:09:38 +0100
Donald Hunter <donald.hunter@...il.com> wrote:

> Kory Maincent <kory.maincent@...tlin.com> writes:
> 
> > From: "Kory Maincent (Dent Project)" <kory.maincent@...tlin.com>
> >
> > Expand the c33 PSE attributes with PSE class, extended state information
> > and power consumption.

> >
> > diff --git a/Documentation/netlink/specs/ethtool.yaml
> > b/Documentation/netlink/specs/ethtool.yaml index 00dc61358be8..8aa064f2f466
> > 100644 --- a/Documentation/netlink/specs/ethtool.yaml
> > +++ b/Documentation/netlink/specs/ethtool.yaml
> > @@ -922,6 +922,22 @@ attribute-sets:
> >          name: c33-pse-pw-d-status
> >          type: u32
> >          name-prefix: ethtool-a-
> > +      -
> > +        name: c33-pse-pw-class
> > +        type: u32
> > +        name-prefix: ethtool-a-
> > +      -
> > +        name: c33-pse-actual-pw
> > +        type: u32
> > +        name-prefix: ethtool-a-
> > +      -
> > +        name: c33-pse-ext-state
> > +        type: u8
> > +        name-prefix: ethtool-a-
> > +      -
> > +        name: c33-pse-ext-substate
> > +        type: u8
> > +        name-prefix: ethtool-a-  
> 
> I see this is consistent with existing pse attributes in the spec, but
> are there enumerations for the state and status attributes that could be
> added to the spec?

Indeed, I can add the enum also in the spec.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com