netdev - Re: [PATCH net V3 0/3] net: lan743x: Fixes for multiple WOL related issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 11 Jun 2024 12:45:44 +0200
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
CC: <lkp@...el.com>, <UNGLinuxDriver@...rochip.com>, <andrew@...n.ch>,
	<bryan.whitehead@...rochip.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <hkallweit1@...il.com>, <hmehrtens@...linear.com>,
	<kuba@...nel.org>, <linux-kernel@...r.kernel.org>, <linux@...linux.org.uk>,
	<lxu@...linear.com>, <netdev@...r.kernel.org>,
	<oe-kbuild-all@...ts.linux.dev>, <pabeni@...hat.com>, <sbauer@...ckbox.su>,
	Wojciech Drewek <wojciech.drewek@...el.com>
Subject: Re: [PATCH net V3 0/3] net: lan743x: Fixes for multiple WOL related
 issues

The 06/11/2024 13:31, Raju Lakkaraju wrote:
> Hi Horatiu,
> 
> There is no new changes except "kernel test robot" reported issue.

So there is no change in the code, you just added the tags between this
version and the previous one where the robot complained?
Because to me it looks like you added an extra #ifdef in 2/3 patch.

> 
> I fix the issue and sent the patch along with other old patches.
> Also add "Reported-by" and "Closes" tags to all patches and
> --in-reply-to=202406052200.w3zuc32H-lkp@...el.com.
> i.e.
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202406052200.w3zuc32H-lkp@intel.com/

It doesn't say to add only if you fix the issue in a separate patch and
not just for a new version of the patch/commit.
Or I miss reading this?

> 
> Is it sufficient? or
> Do you need to generete new version of patches ?

Every time when you do a change in your patch until is accepted, you
will need to generate a new version.
Don't forget about 24h rule. That you need to wait 24h before you can
send a new version.

> 
> Thanks,
> Raju
> The 06/11/2024 09:10, Horatiu Vultur wrote:
> > Hi Raju,
> > 
> > Is this not supposed to be v4?
> > Because I can see v3 here:
> > https://www.spinics.net/lists/netdev/msg1002225.html
> > 
> > The 06/11/2024 11:57, Raju Lakkaraju wrote:
> > > This patch series implement the following fixes:
> > > 1. Disable WOL upon resume in order to restore full data path operation
> > > 2. Support WOL at both the PHY and MAC appropriately 
> > > 3. Remove interrupt mask clearing from config_init 
> > > 
> > > Patch-3 was sent seperately earlier. Review comments in link: 
> > > https://lore.kernel.org/lkml/4a565d54-f468-4e32-8a2c-102c1203f72c@lunn.ch/T/
> > > 
> > > Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>                        
> > > Reported-by: kernel test robot <lkp@...el.com>                                  
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202406052200.w3zuc32H-lkp@intel.com/
> > 
> > I think you should drop the 'Reported-by' and 'Closes' tags because the
> > issue that is getting closed is the one that you introduced in one of
> > your previous version of the patch series.
> > 
> > > 
> > > Raju Lakkaraju (3):
> > >   net: lan743x: disable WOL upon resume to restore full data path
> > >     operation
> > >   net: lan743x: Support WOL at both the PHY and MAC appropriately
> > >   net: phy: mxl-gpy: Remove interrupt mask clearing from config_init
> > > 
> > >  .../net/ethernet/microchip/lan743x_ethtool.c  | 44 ++++++++++++--
> > >  drivers/net/ethernet/microchip/lan743x_main.c | 46 ++++++++++++---
> > >  drivers/net/ethernet/microchip/lan743x_main.h | 28 +++++++++
> > >  drivers/net/phy/mxl-gpy.c                     | 58 ++++++++++++-------
> > >  4 files changed, 144 insertions(+), 32 deletions(-)
> > > 
> > > -- 
> > > 2.34.1
> > > 
> > > 
> > 
> > -- 
> > /Horatiu
> 
> -- 
> Thanks,                                                                         
> Raju

-- 
/Horatiu