netdev - Re: [PATCH] [net] ravb: RAVB should select PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab8f2f03-071f-4d87-97ce-c34c4672135d@bp.renesas.com>
Date: Tue, 11 Jun 2024 15:37:07 +0100
From: Paul Barker <paul.barker.ct@...renesas.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>,
 Sergey Shtylyov <s.shtylyov@....ru>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH] [net] ravb: RAVB should select PAGE_POOL

On 11/06/2024 14:48, Geert Uytterhoeven wrote:
> If CONFIG_PAGE_POOL is not enabled:
> 
>     aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected!
>     aarch64-linux-gnu-ld: Unexpected run-time procedure linkages detected!
>     aarch64-linux-gnu-ld: drivers/net/ethernet/renesas/ravb_main.o: in function `ravb_rx_ring_refill':
>     ravb_main.c:(.text+0x8d8): undefined reference to `page_pool_alloc_pages'
>     aarch64-linux-gnu-ld: ravb_main.c:(.text+0x944): undefined reference to `page_pool_alloc_frag'
>     aarch64-linux-gnu-ld: drivers/net/ethernet/renesas/ravb_main.o: in function `ravb_ring_init':
>     ravb_main.c:(.text+0x1d4c): undefined reference to `page_pool_create'
> 
> Fixes: 966726324b7b1400 ("net: ravb: Allocate RX buffers via page pool")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>  drivers/net/ethernet/renesas/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/renesas/Kconfig b/drivers/net/ethernet/renesas/Kconfig
> index b03fae7a0f72ec5e..83de7e56da61bbb1 100644
> --- a/drivers/net/ethernet/renesas/Kconfig
> +++ b/drivers/net/ethernet/renesas/Kconfig
> @@ -33,6 +33,7 @@ config RAVB
>  	select CRC32
>  	select MII
>  	select MDIO_BITBANG
> +	select PAGE_POOL
>  	select PHYLIB
>  	select RESET_CONTROLLER
>  	help

Ah, I missed that page pool support can be enabled/disabled with a
config option. Thanks for fixing this!

Reviewed-by: Paul Barker <paul.barker.ct@...renesas.com>

-- 
Paul Barker
Download attachment "OpenPGP_0x27F4B3459F002257.asc" of type "application/pgp-keys" (3521 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)