netdev - Re: [iwl-net][PATCH] Revert "e1000e: move force SMBUS near the end of enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3359c6cb-cd2a-4738-8907-5018fa3e9606@canonical.com>
Date: Tue, 11 Jun 2024 13:43:49 +0800
From: Hui Wang <hui.wang@...onical.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>, intel-wired-lan@...ts.osuosl.org,
 netdev@...r.kernel.org, kuba@...nel.org, anthony.l.nguyen@...el.com,
 vitaly.lifshits@...el.com, dima.ruinskiy@...el.com, davem@...emloft.net,
 pabeni@...hat.com, edumazet@...gle.com, sasha.neftin@...el.com,
 naamax.meir@...ux.intel.com
Cc: todd.e.brandt@...el.com, dmummenschanz@....de, rui.zhang@...el.com,
 jacob.e.keller@...el.com, horms@...nel.org, regressions@...ts.linux.dev
Subject: Re: [iwl-net][PATCH] Revert "e1000e: move force SMBUS near the end of
 enable_ulp function"


On 6/10/24 14:36, Paul Menzel wrote:
> Dear Hui,
>
>
> Thank you for your patch.
>
>
> Am 10.06.24 um 03:32 schrieb Hui Wang:
>> This reverts commit bfd546a552e140b0a4c8a21527c39d6d21addb28
>>
>> Commit bfd546a552e1 ("e1000e: move force SMBUS near the end of
>> enable_ulp function") introduces system suspend failure on some
>> ethernet cards, at the moment, the pciid of the affected ethernet
>> cards include [8086:15b8] and [8086:15bc].
>>
>> About the regression the commit bfd546a552e1 ("e1000e: move force
>
> … regression introduced by commit …
Got it.
>
>> SMBUS near the end of enable_ulp function") tried to fix, looks like
>> it is not trivial to fix, we need to find a better way to resolve it.
>
> Please send a revert for commit 861e8086029e (e1000e: move force SMBUS 
> from enable ulp function to avoid PHY loss issue), present since Linux 
> v6.9-rc3 and not containing enough information in the commit messsage, 
> so we have a proper baseline. (That’s also why I originally suggested 
> to split it into two commits (revert + your change).)

In regards to reverting the commit 861e8086029e (e1000e: move force 
SMBUS from enable ulp function to avoid PHY loss issue), the author is 
Vitaly, let him evaluate how to act.

Thanks.

>