[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1f5000c4-30cd-40fd-b610-24366a15fd6c@foss.st.com>
Date: Wed, 12 Jun 2024 08:07:07 +0200
From: Christophe ROULLIER <christophe.roullier@...s.st.com>
To: Marek Vasut <marex@...x.de>, "David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo
Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>,
Krzysztof
Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley
<conor+dt@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre
Torgue <alexandre.torgue@...s.st.com>,
Richard Cochran
<richardcochran@...il.com>,
Jose Abreu <joabreu@...opsys.com>,
Liam Girdwood
<lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>
CC: <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-stm32@...md-mailman.stormreply.com>,
<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [net-next,PATCH v7 7/8] net: stmmac: dwmac-stm32: Mask support
for PMCR configuration
Hi Marek,
On 6/11/24 18:16, Marek Vasut wrote:
> On 6/11/24 3:32 PM, Christophe ROULLIER wrote:
>>
>> On 6/11/24 15:07, Marek Vasut wrote:
>>> On 6/11/24 10:36 AM, Christophe Roullier wrote:
>>>
>>> [...]
>>>
>>>> static void stm32_dwmac_clk_disable(struct stm32_dwmac *dwmac,
>>>> bool suspend)
>>>> @@ -348,8 +352,15 @@ static int stm32_dwmac_parse_data(struct
>>>> stm32_dwmac *dwmac,
>>>> return PTR_ERR(dwmac->regmap);
>>>> err = of_property_read_u32_index(np, "st,syscon", 1,
>>>> &dwmac->mode_reg);
>>>> - if (err)
>>>> + if (err) {
>>>> dev_err(dev, "Can't get sysconfig mode offset (%d)\n", err);
>>>> + return err;
>>>> + }
>>>> +
>>>> + dwmac->mode_mask = SYSCFG_MP1_ETH_MASK;
>>>> + err = of_property_read_u32_index(np, "st,syscon", 2,
>>>> &dwmac->mode_mask);
>>>> + if (err)
>>>> + dev_dbg(dev, "Warning sysconfig register mask not set\n");
>>>
>>> My comment on V6 was not addressed I think ?
>>
>> Hi Marek,
>>
>> I put the modification in patch which introduce MP13 (V7 8/8) ;-)
>>
>> err = of_property_read_u32_index(np, "st,syscon", 2,
>> &dwmac->mode_mask);
>> - if (err)
>> - dev_dbg(dev, "Warning sysconfig register mask not set\n");
>> + if (err) {
>> + if (dwmac->ops->is_mp13)
>> + dev_err(dev, "Sysconfig register mask must be set
>> (%d)\n", err);
>> + else
>> + dev_dbg(dev, "Warning sysconfig register mask not set\n");
>> + }
>
> That isn't right, is it ?
>
> For MP2 , this still checks the presence of syscon , which shouldn't
> be checked at all for MP2 as far as I understand it ?
When I will push MP2 serie, I will bypass the check of mask syscfg. I
will push MP2 after MP13 ack.
Thanks
Powered by blists - more mailing lists